Ensure duplexer stop entails a websocket close #3246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jondequinor
added
the
release-notes:maintenance
Codecov Report
@@ Coverage Diff @@
## main #3246 +/- ##
=======================================
Coverage 65.61% 65.62%
=======================================
Files 619 619
Lines 48887 48894 +7
Branches 4404 4404
=======================================
+ Hits 32076 32085 +9
+ Misses 15310 15307 -3
- Partials 1501 1502 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
verveerpj
approved these changes
Apr 11, 2022
jondequinor
force-pushed
the
fix-3137.1
branch
2 times, most recently
from
3dfe652
to
df95af4
Compare
25 tasks
- If immediately stopped, the duplexer might not have closed the connection it made. This will appear as a fault on the server side with a code 1006 (connection closed abnormally), and the server handler will terminate expectedly. This change will ensure that a duplexer cannot be used until a connection has been made, meaning `stop` will have closed the connection. - This fix also revealed a programming error in the prefect ensemble where a failure in running the flow would not be handled properly, such as in the case of cancellation. See also equinor#2759 which discusses failures. - Also renamed tests so that they will not be confused with each other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #3137
If immediately stopped, the duplexer might not have closed the
connection it made. This will appear as a fault on the server side
with a code 1006 (connection closed abnormally), and the server handler
will terminate expectedly.
This change will ensure that a duplexer cannot be used until a
connection has been made, meaning
stopwill close the connection and not fail.Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.