Avoid BoolVector in Python code #3251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berland
added
the
release-notes:maintenance
berland
force-pushed
the
port_handling_active_range
branch
from
cb117d3
to
1689abb
Compare
berland
changed the title
berland
force-pushed
the
port_handling_active_range
branch
5 times, most recently
from
410f10b
to
6bbb828
Compare
xjules
reviewed
Apr 20, 2022
| @@ -83,7 +84,7 @@ def run_path(self): | |||
| return self._enkf_main.getModelConfig().getRunpathAsString() | |||
|
|
|||
| def load_from_forward_model( | |||
| self, case: str, realisations: BoolVector, iteration: int | |||
| self, case: str, realisations: List[bool], iteration: int | |||
There was a problem hiding this comment.
I see that we use both spelling for realization and realisation. Maybe we should unify them at same point.
There was a problem hiding this comment.
Yes, that would be an issue of its own.
xjules
reviewed
Apr 20, 2022
berland
force-pushed
the
port_handling_active_range
branch
3 times, most recently
from
6594c70
to
812b5cd
Compare
Codecov Report
@@ Coverage Diff @@
## main #3251 +/- ##
==========================================
- Coverage 64.90% 64.90% -0.01%
==========================================
Files 619 619
Lines 48709 48647 -62
Branches 4370 4370
==========================================
- Hits 31617 31572 -45
+ Misses 15652 15632 -20
- Partials 1440 1443 +3
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
berland
force-pushed
the
port_handling_active_range
branch
from
812b5cd
to
f5655f3
Compare
sondreso
reviewed
Apr 21, 2022
berland
force-pushed
the
port_handling_active_range
branch
from
6aa270e
to
d9b5b66
Compare
|
jenkins test pleas |
berland
force-pushed
the
port_handling_active_range
branch
from
d9b5b66
to
f3d60f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #3121
Resolves #3141
Approach
Replace usage of
BoolVectorwithList[bool]except for the final call to wrapped C-code. Use new Python objectActiveRangefor interpreting range strings.Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.