Remove matrix type from ert #3268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManInFez
added
the
release-notes:maintenance
After converting all usage of matrix to Eigen we now remove matrix.hpp and all corresponding tetsts
ManInFez
force-pushed
the
remove_matrix_type
branch
from
5572c9a
to
c94e55e
Compare
oyvindeide
reviewed
Apr 20, 2022
While the covariance matrix could be loaded it was never used. Removing all remnance of covariance matrix in code and documentation
ManInFez
force-pushed
the
remove_matrix_type
branch
from
228cbb2
to
7743576
Compare
oyvindeide
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #2904
Approach
Short description of the approach
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.