Remove analysis enums #3283
Merged
Remove analysis enums #3283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManInFez
added
the
release-notes:breaking-change
ManInFez
force-pushed
the
remove_analysis_enums
branch
2 times, most recently
from
cc76208
to
19281ed
Compare
|
test this please! |
ManInFez
force-pushed
the
remove_analysis_enums
branch
from
19281ed
to
0a44d02
Compare
oyvindeide
reviewed
Apr 22, 2022
ManInFez
force-pushed
the
remove_analysis_enums
branch
5 times, most recently
from
878c3e1
to
4e8d3fb
Compare
|
test this please! |
ManInFez
force-pushed
the
remove_analysis_enums
branch
from
cfdd8a3
to
ea24390
Compare
oyvindeide
reviewed
Apr 25, 2022
| elif variable_type == int: | ||
| return analysis_module.getInt(name) | ||
| else: | ||
| logger.error(f"Unknown variable: {name} of type: {variable_type}") |
There was a problem hiding this comment.
The replacement here no longer has an: else, should perhaps add that?
There was a problem hiding this comment.
Asserting variable in getvar-function and raising exception if not valid nor supported type
oyvindeide
approved these changes
Apr 25, 2022
The analysis module is strictly connected to which type of experiment is being ran. ES and ES_MDA use STD_ENKF and IES uses IES_ENKF. These are now hard coded
two, and their properties are not mutable.
ManInFez
force-pushed
the
remove_analysis_enums
branch
3 times, most recently
from
1aa5890
to
659bdb1
Compare
Codecov Report
@@ Coverage Diff @@
## main #3283 +/- ##
==========================================
- Coverage 64.96% 64.87% -0.09%
==========================================
Files 618 615 -3
Lines 48498 48356 -142
Branches 4363 4359 -4
==========================================
- Hits 31506 31373 -133
+ Misses 15543 15528 -15
- Partials 1449 1455 +6
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
ManInFez
force-pushed
the
remove_analysis_enums
branch
from
659bdb1
to
0aa20ae
Compare
ManInFez
force-pushed
the
remove_analysis_enums
branch
from
0aa20ae
to
4656aef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #3266
Approach
Short description of the approach
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.