Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fixtures cleanup after themselves #3287

Merged
merged 2 commits into from
Apr 22, 2022
Merged

Make fixtures cleanup after themselves #3287

merged 2 commits into from
Apr 22, 2022

Conversation

verveerpj
Copy link
Contributor

@verveerpj verveerpj commented Apr 21, 2022

Issue
Resolves #3279

Approach
Make sure that fixtures that create the poly.py file clean it up after yielding.

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@verveerpj verveerpj added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Apr 21, 2022
@verveerpj verveerpj self-assigned this Apr 21, 2022
@berland
Copy link
Contributor

berland commented Apr 21, 2022

@verveerpj
Copy link
Contributor Author

Should we consider adding a test for this similar to https://github.com/equinor/subscript/blob/f41b90e0945ce1f5e838039e2f865a56dd3d6bf9/.github/workflows/subscript.yml#L74-L76 ?

Excellent idea, will do.

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2022

Codecov Report

Merging #3287 (f1b8e73) into main (b708b59) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3287   +/-   ##
=======================================
  Coverage   64.91%   64.91%           
=======================================
  Files         618      618           
  Lines       48504    48504           
  Branches     4368     4368           
=======================================
  Hits        31486    31486           
+ Misses      15565    15563    -2     
- Partials     1453     1455    +2     
Impacted Files Coverage Δ
libres/lib/res_util/block_fs.cpp 52.08% <0.00%> (-0.47%) ⬇️
ert_gui/simulation/run_dialog.py 81.53% <0.00%> (+0.76%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@verveerpj verveerpj force-pushed the remove-poly.py branch 8 times, most recently from f6c81c1 to 375385a Compare April 22, 2022 10:34
@verveerpj verveerpj closed this Apr 22, 2022
@verveerpj verveerpj reopened this Apr 22, 2022
@berland berland merged commit 586cc60 into main Apr 22, 2022
@berland berland deleted the remove-poly.py branch April 22, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poly.py file in source tree after running tests
3 participants