Raise exception if analysis can not be performed #3302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManInFez
force-pushed
the
raise_exception_on_analysis_failure
branch
3 times, most recently
from
79d4e83
to
5078dd7
Compare
ManInFez
force-pushed
the
raise_exception_on_analysis_failure
branch
6 times, most recently
from
0d79ab9
to
15f0b62
Compare
Codecov Report
@@ Coverage Diff @@
## main #3302 +/- ##
=======================================
Coverage 64.94% 64.95%
=======================================
Files 616 616
Lines 48276 48275 -1
Branches 4331 4331
=======================================
Hits 31355 31355
+ Misses 15484 15478 -6
- Partials 1437 1442 +5
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
ManInFez
added
the
release-notes:breaking-change
ManInFez
force-pushed
the
raise_exception_on_analysis_failure
branch
5 times, most recently
from
d18fb36
to
dd76829
Compare
oyvindeide
reviewed
Apr 28, 2022
ManInFez
force-pushed
the
raise_exception_on_analysis_failure
branch
from
dd76829
to
153639d
Compare
jondequinor
reviewed
Apr 28, 2022
res/enkf/es_update.py
Outdated
| ) | ||
| if len(updatestep) > 1 and module.name() == "IES_ENKF": | ||
| raise ErtAnalysisError( | ||
| "Can not combine IES_ENKF modules with multi step " "updates" |
ManInFez
force-pushed
the
raise_exception_on_analysis_failure
branch
2 times, most recently
from
4fa9852
to
23fc546
Compare
Raising exceptions will terminate the experiment and potentially the whole application if analysis can not be performed
ManInFez
force-pushed
the
raise_exception_on_analysis_failure
branch
from
23fc546
to
469d260
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #3008
Approach
Short description of the approach
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.