Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease example size for polynomial doe #3304

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

berland
Copy link
Contributor

@berland berland commented Apr 26, 2022

Having the size at 1000 just takes a lot of minutes during
testing and does not increase test coverage. Reduced to an
ensemble size of 50.

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

Having the size at 1000 just takes a lot of minutes during
testing and does not add particularly much. Reduced to an
ensemble size of 50.
@berland berland added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Apr 26, 2022
@berland berland self-assigned this Apr 26, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3304 (6dd9f14) into main (bdb2615) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3304      +/-   ##
==========================================
+ Coverage   64.87%   64.89%   +0.02%     
==========================================
  Files         615      615              
  Lines       48355    48355              
  Branches     4359     4359              
==========================================
+ Hits        31369    31379      +10     
+ Misses      15531    15528       -3     
+ Partials     1455     1448       -7     
Impacted Files Coverage Δ
ert/data/record/_transformation.py 89.04% <0.00%> (+0.47%) ⬆️
libres/lib/enkf/block_fs_driver.cpp 72.51% <0.00%> (+0.58%) ⬆️
ert_gui/simulation/run_dialog.py 80.30% <0.00%> (+0.75%) ⬆️
libres/lib/res_util/block_fs.cpp 53.00% <0.00%> (+1.38%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@berland berland enabled auto-merge (rebase) April 26, 2022 10:41
@berland berland merged commit e0529a8 into equinor:main Apr 26, 2022
@berland berland deleted the polynomial_size50 branch June 15, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants