Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch unexpected exceptions and clean up to avoid hanging GUI #3315

Merged

Conversation

BjarneHerland
Copy link
Contributor

Resolves #3244

Approach
Prevent exceptions to pass the EvaluatorTracker as this seems to be able to freeze Qt.

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

@BjarneHerland BjarneHerland added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Apr 28, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3315 (96dbc4f) into main (fc25cf2) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3315      +/-   ##
==========================================
- Coverage   64.95%   64.94%   -0.02%     
==========================================
  Files         616      616              
  Lines       48273    48282       +9     
  Branches     4331     4331              
==========================================
  Hits        31356    31356              
- Misses      15474    15482       +8     
- Partials     1443     1444       +1     
Impacted Files Coverage Δ
...rt/ensemble_evaluator/tracker/evaluator_tracker.py 72.22% <0.00%> (-2.99%) ⬇️
ert_gui/tools/plot/plot_api.py 80.00% <0.00%> (-2.36%) ⬇️
ert_data/measured.py 85.71% <0.00%> (-1.67%) ⬇️
libres/lib/res_util/block_fs.cpp 66.46% <0.00%> (-0.31%) ⬇️
ert_gui/gert_main.py 96.20% <0.00%> (ø)
ert_gui/about_dialog.py 20.68% <0.00%> (ø)
ert_gui/plottery/plot_style.py 97.75% <0.00%> (ø)
ert_gui/tools/file/file_dialog.py 17.72% <0.00%> (ø)
ert_gui/ertwidgets/caseselector.py 77.50% <0.00%> (ø)
ert_gui/tools/export/export_tool.py 54.54% <0.00%> (ø)
... and 4 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@BjarneHerland BjarneHerland merged commit 181ee57 into equinor:main Apr 29, 2022
BjarneHerland added a commit to BjarneHerland/ert that referenced this pull request May 5, 2022
Like EvaluatorTracker this code also does _Monitor.track() and is thus
exposed to the same unexpected exceptions as were handled in equinor#3315.
BjarneHerland added a commit to BjarneHerland/ert that referenced this pull request May 5, 2022
Like EvaluatorTracker this code also does _Monitor.track() and is thus
exposed to the same unexpected exceptions as were handled in equinor#3315.
BjarneHerland added a commit to BjarneHerland/ert that referenced this pull request May 6, 2022
Like EvaluatorTracker this code also does _Monitor.track() and is thus
exposed to the same unexpected exceptions as were handled in equinor#3315.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress dialog hangs
3 participants