Log maximum memory usage in main ERT thread #3357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3357 +/- ##
=======================================
Coverage 63.52% 63.53%
=======================================
Files 603 603
Lines 46480 46494 +14
Branches 4140 4140
=======================================
+ Hits 29526 29538 +12
- Misses 15667 15669 +2
Partials 1287 1287
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
pinkwah
force-pushed
the
memuse
branch
2 times, most recently
from
7b85a91
to
d81ec65
Compare
ManInFez
reviewed
May 9, 2022
sregales-TNO
added
the
telemetry
pinkwah
force-pushed
the
memuse
branch
4 times, most recently
from
49b101a
to
9fc896d
Compare
oyvindeide
reviewed
Jun 27, 2022
|
If you rebase this again it should be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #2986
The terminology is a bit obtuse. RSS is "Resident Set Size", which is the amount of RAM that the program is using. This number does not include swap (when paging out) or on disk (because parts of the program haven't been loaded). I have chosen to use "Peak memory use" instead so that it's understandable without having to duckduckgo what RSS means.
Virtual memory usage is another metric that is possible to record, but is not useful for this purpose. Basically, the 64-bit address space doesn't actually need to be RAM, and the OS can map other stuff to that area. A simple example is
mmap, which opens a file and lets the user access it as if it were in memory, but really it's still on disk. So instead of.read()/.write(), you can just read from a byte array directly. We don't care about this number though.Compare results with
/usr/bin/time -v ert test_run snake_oil.ert. The-vwill record "Maximum RSS" which is the peak memory usage.