Refactor analysis config min_required_realizations #3426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default min_realizations to num_realizations when parsing config. Remove ensemble_size parameter for analysis_config.haveEnoughRealisations()
ManInFez
added
the
release-notes:breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Analysis config is provided enough information during initialization, but was previously also requiring one to add the
pass in ensemble size as a parameter. This is no longer needed, as min_required now defaults to ensemble size
if nothing is specified.
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.