Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor loading parameter matrices out of make_update_data #3429

Merged
merged 1 commit into from
May 24, 2022

Conversation

ManInFez
Copy link
Contributor

The loading and saving of paramter matrices are binded to python
and called directly from es_update

Issue
Resolves #my_issue

Approach
Short description of the approach

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

The loading and saving of paramter matrices are binded to python
and called directly from es_update
@codecov-commenter
Copy link

Codecov Report

Merging #3429 (2eb7fa7) into main (65f1334) will increase coverage by 0.00%.
The diff coverage is 46.42%.

@@           Coverage Diff           @@
##             main    #3429   +/-   ##
=======================================
  Coverage   65.27%   65.27%           
=======================================
  Files         603      603           
  Lines       47728    47727    -1     
  Branches     4234     4220   -14     
=======================================
+ Hits        31155    31156    +1     
+ Misses      15217    15213    -4     
- Partials     1356     1358    +2     
Impacted Files Coverage Δ
libres/lib/include/ert/analysis/update.hpp 0.00% <0.00%> (ø)
libres/lib/analysis/update.cpp 36.66% <40.00%> (-1.45%) ⬇️
res/enkf/es_update.py 96.51% <100.00%> (+0.12%) ⬆️
libres/lib/res_util/block_fs.cpp 67.69% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@dafeda dafeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ManInFez ManInFez merged commit 6154db1 into equinor:main May 24, 2022
@ManInFez ManInFez deleted the remove_A_from_update_data branch May 24, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants