-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update about-section of readme #3442
Conversation
README.md
Outdated
ERT - Ensemble based Reservoir Tool - is designed for running | ||
ensembles of dynamical models such as reservoir models, | ||
in order to do sensitivity analysis and data assimilation. | ||
Supports data assimilation using ES, ES-MDA and IES. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can type out ES, ES-MDA and IES
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
README.md
Outdated
ERT - Ensemble based Reservoir Tool - is designed for running | ||
ensembles of dynamical models such as reservoir models, | ||
in order to do sensitivity analysis and data assimilation. | ||
Supports data assimilation using the Ensemble Smoother (ES), | ||
Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and | ||
Iterative Ensemble Smoother (IES). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ERT - Ensemble based Reservoir Tool - is designed for running | |
ensembles of dynamical models such as reservoir models, | |
in order to do sensitivity analysis and data assimilation. | |
Supports data assimilation using the Ensemble Smoother (ES), | |
Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and | |
Iterative Ensemble Smoother (IES). | |
ERT - Ensemble based Reservoir Tool - is designed for running | |
ensembles of dynamical models such as reservoir models, | |
in order to do sensitivity analysis and data assimilation. | |
Supports data assimilation using the Ensemble Smoother (ES), | |
Ensemble Smoother with Multiple Data Assimilation (ES-MDA) and | |
Iterative Ensemble Smoother (IES) methods. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or algorithms or something..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that is necessary since a "Smoother" is a known method.
Hence a sentence like "Data assimilation using the Ensemble Smoother." is complete.
README.md
Outdated
ERT - Ensemble based Reservoir Tool - is designed for running | ||
ensembles of dynamical models such as reservoir models, | ||
in order to do sensitivity analysis and data assimilation. | ||
Supports data assimilation using the Ensemble Smoother (ES), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Supports" -> "It supports" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose "ERT supports" since "It" leads to the sentence being in the passive voice which I don't particularly like.
Codecov Report
@@ Coverage Diff @@
## main #3442 +/- ##
==========================================
+ Coverage 60.81% 65.33% +4.51%
==========================================
Files 314 603 +289
Lines 31386 47736 +16350
Branches 4221 4221
==========================================
+ Hits 19088 31186 +12098
- Misses 10781 15190 +4409
+ Partials 1517 1360 -157
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Issue
Resolves #my_issue
Approach
Short description of the approach
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.