Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix iteration nr bug in IES and add ies cli integration test #3457

Merged
merged 1 commit into from
May 31, 2022
Merged

Fix iteration nr bug in IES and add ies cli integration test #3457

merged 1 commit into from
May 31, 2022

Conversation

ManInFez
Copy link
Contributor

Issue
Resolves #my_issue

Approach
Short description of the approach

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@ManInFez ManInFez added the release-notes:bug-fix Automatically categorise as bug fix in release notes label May 31, 2022
@ManInFez ManInFez force-pushed the add_ies_cli_integration_test branch 2 times, most recently from 98be38e to 7394b9f Compare May 31, 2022 07:24
oyvindeide
oyvindeide approved these changes May 31, 2022
View reviewed changes
Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But can you update the PR text and squash to one commit? Good to have the failing test in the same commit as the fix.

@ManInFez
Add integration test running ies
de3945f 
Fix iteration nr bug in ies
@ManInFez ManInFez force-pushed the add_ies_cli_integration_test branch from 7394b9f to de3945f Compare May 31, 2022 07:29
@ManInFez ManInFez changed the title Add ies cli integration test Fix iteration nr bug in IES and add ies cli integration test May 31, 2022
@ManInFez ManInFez merged commit 1d74e57 into equinor:main May 31, 2022
@ManInFez ManInFez deleted the add_ies_cli_integration_test branch May 31, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oyvindeide oyvindeide oyvindeide approved these changes

Assignees
No one assigned
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ManInFez @oyvindeide