Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.6 and Python 3.7 #3490

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Conversation

sondreso
Copy link
Collaborator

@sondreso sondreso commented Jun 8, 2022

Issue
Python 3.6 is EOL and Python 3.7 support has already been dropped by popular packages such as numpy. We also no longer need to support Python 3.6/3.7 for internal deploys.

Approach
Drop support for Python 3.6 and 3.7

Note:
Required tests will be changed after this is approved

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@sondreso sondreso added release-notes:breaking-change Automatically categorise as breaking change in release notes release-notes:maintenance Automatically categorise as maintenance change in release notes labels Jun 8, 2022
@sondreso sondreso self-assigned this Jun 8, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3490 (db75e81) into main (a1eab17) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main    #3490   +/-   ##
=======================================
  Coverage   64.97%   64.97%           
=======================================
  Files         601      601           
  Lines       47399    47391    -8     
  Branches     4114     4114           
=======================================
- Hits        30796    30791    -5     
+ Misses      15299    15293    -6     
- Partials     1304     1307    +3     
Impacted Files Coverage Δ
ert_shared/models/types.py 0.00% <0.00%> (ø)
..._shared/ensemble_evaluator/narratives/narrative.py 84.63% <100.00%> (+0.30%) ⬆️
libres/lib/res_util/block_fs.cpp 67.27% <0.00%> (-0.92%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@sondreso sondreso force-pushed the drop-py36 branch 2 times, most recently from ed719bf to 8df8c40 Compare June 9, 2022 13:33
setup.py Show resolved Hide resolved
@sondreso sondreso marked this pull request as ready for review June 10, 2022 08:49
Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️ 👍🏻

@berland
Copy link
Contributor

berland commented Jun 20, 2022

There are more things that should be cleaned up in this PR. Do a grep for sys.version and a handful of cases will be found.

Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix more sys.version issues.

@sondreso sondreso force-pushed the drop-py36 branch 3 times, most recently from b2a427f to 58b4a97 Compare June 20, 2022 12:15
@sondreso
Copy link
Collaborator Author

Jenkins test this please

@sondreso sondreso merged commit b242504 into equinor:main Jun 27, 2022
@sondreso sondreso deleted the drop-py36 branch June 27, 2022 12:31
@sondreso sondreso removed the blocked label Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:breaking-change Automatically categorise as breaking change in release notes release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants