Improve feedback to users when callbacks fail #3534

oyvindeide · 2022-06-16T09:48:26Z

Issue
Related to: #3417

Approach
Short description of the approach

Pre review checklist

Added appropriate release note label
PR title captures the intent of the changes, and is fitting for release notes.
Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

codecov-commenter · 2022-06-21T17:09:34Z

Codecov Report

Merging #3534 (5b93ff1) into main (a6c0e8c) will decrease coverage by 0.11%.
The diff coverage is 18.81%.

@@            Coverage Diff             @@
##             main    #3534      +/-   ##
==========================================
- Coverage   65.01%   64.90%   -0.12%     
==========================================
  Files         599      592       -7     
  Lines       46989    46651     -338     
  Branches     4210     4263      +53     
==========================================
- Hits        30549    30277     -272     
+ Misses      15065    14992      -73     
- Partials     1375     1382       +7

Impacted Files	Coverage Δ
ert/ensemble_evaluator/state.py	`100.00% <ø> (+8.69%)`	⬆️
libres/lib/enkf/enkf_main.cpp	`39.66% <0.00%> (-0.11%)`	⬇️
libres/lib/enkf/enkf_state.cpp	`25.09% <0.00%> (+1.32%)`	⬆️
libres/lib/enkf/ensemble_config.cpp	`46.75% <0.00%> (-0.18%)`	⬇️
libres/lib/python/model_callbacks.cpp	`6.66% <0.00%> (-3.34%)`	⬇️
libres/lib/enkf/time_map.cpp	`48.16% <18.91%> (+3.57%)`	⬆️
res/job_queue/job_queue_node.py	`92.94% <100.00%> (+0.23%)`	⬆️
ert_shared/dark_storage/common.py	`67.46% <0.00%> (-9.28%)`	⬇️
ert_shared/dark_storage/enkf.py	`93.02% <0.00%> (-2.33%)`	⬇️
ert_shared/dark_storage/app.py	`78.78% <0.00%> (-1.22%)`	⬇️
... and 11 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

libres/lib/enkf/time_map.cpp

dafeda

LGTM 👍

This has the side effect that we now check every step of the time map, even though we have a failure, thus the size of the index map has changed.

This allows us to move logging to job_queue_node where we have more context

oyvindeide force-pushed the remove_log_mismatch branch 7 times, most recently from 489700d to c02d57e Compare June 21, 2022 16:39

oyvindeide force-pushed the remove_log_mismatch branch 8 times, most recently from ed357f0 to dc79024 Compare June 22, 2022 06:46

oyvindeide self-assigned this Jun 22, 2022

oyvindeide added the release-notes:improvement Automatically categorise as improvement in release notes label Jun 22, 2022

oyvindeide changed the title ~~Return error message instead of bool~~ Improve feedback to users when callbacks fail Jun 22, 2022