-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proxy script for qstat #3553
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3553 +/- ##
==========================================
- Coverage 63.34% 63.28% -0.06%
==========================================
Files 597 595 -2
Lines 46243 46198 -45
Branches 4144 4156 +12
==========================================
- Hits 29293 29237 -56
- Misses 15662 15667 +5
- Partials 1288 1294 +6
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
92ca9b0
to
de8e3e5
Compare
TODO:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you choose bash? flock (fcntl
), stat, cat should all be supported by python stdlib.
Unless there's a really good reason to choose bash, we should choose the portable python route.
For example, try building a komodo distribution on macos. It will fail mostly because it assumes rename
, rmdir
to come from coreutils
, which on macos they do not.
|
eb2062b
to
11de59f
Compare
dev-requirements.txt
Outdated
@@ -1,9 +1,12 @@ | |||
click | |||
cmake-format | |||
decorator | |||
ecl_data_io | |||
ecl_data_io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2x the same
Just to recap our discussion: add one more test to check that |
Rebase pending reviewer @xjules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice @berland ! Very good job! 🚀
This shell script is significantly faster to run compared to the real qstat ("backend") as it only greps in a file on /tmp. The file on /tmp acts as a cache, and will be updated whenever it gets too old (~seconds). The queue manager in ERT polls the queing system (that is qstat) once pr. second for every realization. This can replicate a DDoS on the cluster queue server, which we mitigate by using this proxy.
Issue
Resolves #3541
Approach
This shell script is significantly faster to run compared to the
real qstat ("backend") as it only greps in a file on /tmp.
The file on /tmp acts as a cache, and will be updated whenever
it gets too old (~seconds).
The queue manager in ERT polls the queing system (that is qstat)
once pr. second for every realization. This can replicate a DDoS on
the cluster queue server, which we mitigate by using this proxy.
Blocked by #3537
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.