Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict annotated files to existing #3634

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

eivindjahren
Copy link
Contributor

The annotation acts up if you move or delete files. This resolves that and removes some unused files in order to test.

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

These are not run in our suite so we should just remove them.
@eivindjahren eivindjahren self-assigned this Jul 25, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3634 (6bb83fa) into main (b4d7258) will increase coverage by 4.99%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3634      +/-   ##
==========================================
+ Coverage   59.74%   64.74%   +4.99%     
==========================================
  Files         313      601     +288     
  Lines       30127    46528   +16401     
  Branches     4186     4186              
==========================================
+ Hits        18000    30124   +12124     
- Misses      10778    15052    +4274     
- Partials     1349     1352       +3     
Impacted Files Coverage Δ
libres/lib/res_util/block_fs.cpp 68.16% <0.00%> (-0.82%) ⬇️
libres/lib/enkf/block_fs_driver.cpp 78.94% <0.00%> (-0.66%) ⬇️
ert/gui/tools/plot/plot_window.py 18.57% <0.00%> (ø)
ert_shared/dark_storage/common.py 67.46% <0.00%> (ø)
ert/gui/tools/load_results/load_results_tool.py 74.19% <0.00%> (ø)
ert/serialization/_evaluator.py 80.00% <0.00%> (ø)
ert3/console/_status.py 100.00% <0.00%> (ø)
ert/gui/tools/load_results/load_results_panel.py 18.75% <0.00%> (ø)
ert/gui/simulation/__init__.py 100.00% <0.00%> (ø)
ert_logging/_log_util_abort.py 92.30% <0.00%> (ø)
... and 294 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@eivindjahren eivindjahren changed the title Restrict files to existing Restrict annotated files to existing Jul 25, 2022
Copy link
Contributor

@dafeda dafeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eivindjahren eivindjahren merged commit 1d5313d into equinor:main Jul 26, 2022
@eivindjahren eivindjahren deleted the restrict_files_to_existing branch July 26, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants