Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort messages so they more likely ordered by realization #3641

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Jul 27, 2022

Issue
Resolves #3435

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@codecov-commenter
Copy link

Codecov Report

Merging #3641 (78d9daf) into main (a829b43) will increase coverage by 0.03%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #3641      +/-   ##
==========================================
+ Coverage   64.44%   64.48%   +0.03%     
==========================================
  Files         594      594              
  Lines       46388    46388              
  Branches     4186     4186              
==========================================
+ Hits        29896    29912      +16     
+ Misses      15140    15125      -15     
+ Partials     1352     1351       -1     
Impacted Files Coverage Δ
src/ert_shared/models/base_run_model.py 76.77% <33.33%> (ø)
src/libres/lib/res_util/block_fs.cpp 68.57% <0.00%> (+0.40%) ⬆️
src/ert/gui/ertwidgets/__init__.py 77.27% <0.00%> (+2.27%) ⬆️
src/ert/gui/ertwidgets/validationsupport.py 98.63% <0.00%> (+19.17%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@oyvindeide oyvindeide self-assigned this Aug 1, 2022
@oyvindeide oyvindeide added the release-notes:improvement Automatically categorise as improvement in release notes label Aug 1, 2022
Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oyvindeide oyvindeide merged commit 3425c78 into equinor:main Aug 3, 2022
@oyvindeide oyvindeide deleted the sort_real branch August 3, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:improvement Automatically categorise as improvement in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

In failed simulations dialog sort entries by realisation and iteration
3 participants