Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite run context to python only #3649

Merged
merged 7 commits into from
Jul 29, 2022

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Jul 28, 2022

Issue
#my_issue

Approach
Short description of the approach

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@oyvindeide oyvindeide force-pushed the rewrite_run_context branch 3 times, most recently from ee1dcff to db0095a Compare July 28, 2022 12:03
@oyvindeide oyvindeide force-pushed the rewrite_run_context branch 3 times, most recently from 4a838d5 to d9deaac Compare July 28, 2022 19:50
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2022

Codecov Report

Merging #3649 (bffc37f) into main (240983f) will increase coverage by 0.06%.
The diff coverage is 73.01%.

@@            Coverage Diff             @@
##             main    #3649      +/-   ##
==========================================
+ Coverage   64.44%   64.51%   +0.06%     
==========================================
  Files         592      590       -2     
  Lines       46386    46157     -229     
  Branches     4186     4161      -25     
==========================================
- Hits        29895    29776     -119     
+ Misses      15141    15038     -103     
+ Partials     1350     1343       -7     
Impacted Files Coverage Δ
src/ert_shared/models/base_run_model.py 77.60% <ø> (+0.82%) ⬆️
src/libres/lib/enkf/enkf_state.cpp 25.20% <ø> (+0.30%) ⬆️
src/libres/lib/enkf/ensemble_config.cpp 46.84% <ø> (+0.08%) ⬆️
src/res/enkf/enkf_simulation_runner.py 97.05% <ø> (+1.34%) ⬆️
src/res/enkf/enums/__init__.py 100.00% <ø> (ø)
src/libres/lib/enkf/enkf_main.cpp 30.44% <6.25%> (-0.38%) ⬇️
src/res/enkf/run_arg.py 87.27% <83.33%> (+5.45%) ⬆️
src/res/enkf/ert_run_context.py 96.82% <97.05%> (+1.58%) ⬆️
src/libres/lib/enkf/run_arg.cpp 72.46% <100.00%> (-6.49%) ⬇️
src/res/enkf/enkf_main.py 89.02% <100.00%> (-0.05%) ⬇️
... and 9 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a massive improvement, but we should keep going in this direction as there is so much more to be cleaned up! I suggest creating a PR investigating this straight away.

src/res/enkf/ert_run_context.py Show resolved Hide resolved
src/res/enkf/ert_run_context.py Show resolved Hide resolved
@oyvindeide
Copy link
Collaborator Author

test this please

@oyvindeide oyvindeide enabled auto-merge (rebase) July 29, 2022 13:38
@oyvindeide oyvindeide merged commit 517c278 into equinor:main Jul 29, 2022
@oyvindeide oyvindeide deleted the rewrite_run_context branch May 2, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants