-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite run context to python only #3649
Conversation
ee1dcff
to
db0095a
Compare
4a838d5
to
d9deaac
Compare
Codecov Report
@@ Coverage Diff @@
## main #3649 +/- ##
==========================================
+ Coverage 64.44% 64.51% +0.06%
==========================================
Files 592 590 -2
Lines 46386 46157 -229
Branches 4186 4161 -25
==========================================
- Hits 29895 29776 -119
+ Misses 15141 15038 -103
+ Partials 1350 1343 -7
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
e3e6159
to
bffc37f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a massive improvement, but we should keep going in this direction as there is so much more to be cleaned up! I suggest creating a PR investigating this straight away.
test this please |
bffc37f
to
0308b99
Compare
This moves the run context into python and removes the C implementation.
0308b99
to
124b538
Compare
Issue
#my_issue
Approach
Short description of the approach
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.