Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logging of conn_info #3670

Merged
merged 3 commits into from
Aug 2, 2022

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Aug 2, 2022

Issue
Cherry pick logging commit.

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

Codecov Report

Merging #3670 (d8963f4) into version-2.37 (7296b84) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           version-2.37    #3670      +/-   ##
================================================
- Coverage         65.05%   65.01%   -0.04%     
================================================
  Files               594      594              
  Lines             46468    46466       -2     
  Branches           4242     4242              
================================================
- Hits              30229    30211      -18     
- Misses            14869    14886      +17     
+ Partials           1370     1369       -1     
Impacted Files Coverage Δ
ert_shared/services/_storage_main.py 26.05% <ø> (+0.43%) ⬆️
ert_gui/ertwidgets/validationsupport.py 79.45% <0.00%> (-19.18%) ⬇️
res/job_queue/forward_model_status.py 88.60% <0.00%> (-5.07%) ⬇️
ert_gui/ertwidgets/__init__.py 75.00% <0.00%> (-2.28%) ⬇️
libres/lib/res_util/block_fs.cpp 68.57% <0.00%> (+0.40%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@oyvindeide oyvindeide merged commit c82e157 into equinor:version-2.37 Aug 2, 2022
@oyvindeide oyvindeide deleted the cherry-pick-log_pwd branch August 2, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants