Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor StateMap into C++ & pybind11 #3693

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Conversation

pinkwah
Copy link
Contributor

@pinkwah pinkwah commented Aug 3, 2022

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #3693 (364571e) into main (aa0b89b) will decrease coverage by 0.17%.
The diff coverage is 48.68%.

@@            Coverage Diff             @@
##             main    #3693      +/-   ##
==========================================
- Coverage   63.28%   63.10%   -0.18%     
==========================================
  Files         595      596       +1     
  Lines       46198    46164      -34     
  Branches     4156     4219      +63     
==========================================
- Hits        29236    29134     -102     
- Misses      15667    15717      +50     
- Partials     1295     1313      +18     
Impacted Files Coverage Δ
src/libres/lib/enkf/enkf_main.cpp 37.12% <0.00%> (-0.43%) ⬇️
src/libres/lib/enkf/enkf_plot_data.cpp 34.04% <0.00%> (+0.70%) ⬆️
src/libres/lib/enkf/enkf_plot_gen_kw.cpp 24.35% <0.00%> (ø)
src/libres/lib/enkf/enkf_plot_gendata.cpp 24.21% <0.00%> (-0.54%) ⬇️
src/libres/lib/include/ert/python.hpp 0.00% <ø> (ø)
src/libres/lib/python/init.cpp 20.51% <0.00%> (-2.07%) ⬇️
src/libres/lib/analysis/update.cpp 40.16% <25.00%> (ø)
src/libres/lib/enkf/enkf_fs.cpp 67.85% <27.77%> (-2.48%) ⬇️
src/libres/lib/enkf/enkf_state.cpp 25.10% <37.50%> (+0.20%) ⬆️
src/libres/lib/enkf/state_map.cpp 59.28% <51.53%> (-30.16%) ⬇️
... and 12 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@pinkwah pinkwah force-pushed the block-storage branch 4 times, most recently from 553e677 to c058d55 Compare August 5, 2022 13:51
@pinkwah pinkwah marked this pull request as ready for review August 5, 2022 14:34
@pinkwah pinkwah force-pushed the block-storage branch 3 times, most recently from 9a2cd4d to 0de3186 Compare August 11, 2022 14:07
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐹 🔨 🐤

@pinkwah pinkwah merged commit 5d60c64 into equinor:main Aug 12, 2022
@pinkwah pinkwah deleted the block-storage branch August 12, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants