Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove python implementation of ForwardLoadContext #3694

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Remove python implementation of ForwardLoadContext #3694

merged 1 commit into from
Aug 4, 2022

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Aug 3, 2022 •
edited

Delete some unused code

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@oyvindeide oyvindeide self-assigned this Aug 3, 2022
@oyvindeide oyvindeide added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Aug 3, 2022
@oyvindeide oyvindeide force-pushed the remove_load_context_py branch 2 times, most recently from 2d90df1 to b4bc945 Compare August 4, 2022 06:39
@oyvindeide oyvindeide marked this pull request as ready for review August 4, 2022 06:44
sondreso
sondreso approved these changes Aug 4, 2022
View reviewed changes
Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oyvindeide oyvindeide merged commit ce638af into equinor:main Aug 4, 2022
@oyvindeide oyvindeide deleted the remove_load_context_py branch May 2, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sondreso sondreso sondreso approved these changes

Assignees

@oyvindeide oyvindeide

Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
SCOUT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oyvindeide @sondreso