Move out res.test.synthesizer to separate package oil_reservoir_synthesizer #3696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eivindjahren
added
the
release-notes:breaking-change
eivindjahren
force-pushed
the
move_to_oil_synthesizer
branch
2 times, most recently
from
7063a67
to
3cf6609
Compare
This example is too complex to come with ert3 by default and depends on libraries which ert3 does not depend on directly. Therefore this example is moved out.
eivindjahren
force-pushed
the
move_to_oil_synthesizer
branch
from
3cf6609
to
cf7b492
Compare
Deletes res.test.synthesizer as it is superseded by oil_reservoir_synthesizer.
eivindjahren
force-pushed
the
move_to_oil_synthesizer
branch
from
cf7b492
to
294ee44
Compare
|
Jenkins is failing due to an unrelated breakage in semeio (rename of |
Codecov Report
@@ Coverage Diff @@
## main #3696 +/- ##
==========================================
+ Coverage 59.67% 63.35% +3.68%
==========================================
Files 299 598 +299
Lines 29519 46225 +16706
Branches 4147 4140 -7
==========================================
+ Hits 17614 29287 +11673
- Misses 10568 15653 +5085
+ Partials 1337 1285 -52
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
oyvindeide
approved these changes
Aug 4, 2022
berland
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
More setup for #3595
Approach
res.test.synthesizeris used by more projects than ert. However, it isn't really part of what ert does. Therefore this functionality is split into its own package. This code then benefits from being independent, which should be good as it:In order to not install this code with ert, snake_oil is removed from ert3_examples. When this functionality is needed later we can add more examples through a plugin architecture.
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.