Join EnKFMain, _RealEnKFMain, EnkfFsManager and EnkfJobRunner in python #3705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyvindeide
force-pushed
the
rejoin_enkf_main
branch
from
cfffe18
to
98230fe
Compare
oyvindeide
force-pushed
the
rejoin_enkf_main
branch
8 times, most recently
from
483745c
to
7e61517
Compare
Codecov Report
@@ Coverage Diff @@
## main #3705 +/- ##
==========================================
- Coverage 63.28% 63.27% -0.01%
==========================================
Files 595 594 -1
Lines 46198 46095 -103
Branches 4156 4156
==========================================
- Hits 29236 29168 -68
+ Misses 15667 15632 -35
Partials 1295 1295
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
oyvindeide
force-pushed
the
rejoin_enkf_main
branch
from
90a4507
to
f49b25a
Compare
oyvindeide
added
the
release-notes:breaking-change
oyvindeide
changed the title
oyvindeide
force-pushed
the
rejoin_enkf_main
branch
7 times, most recently
from
d3d8078
to
18fe4d9
Compare
This joins the different classes that all point to the underlying C++ object enkf_main so there is a 1 to 1 relationship. The reason for doing this is that the split introduces a lot of complexity, and no real separation of conserns, as the subclasses often have to call parent(). There was also a lot of additional complexity added on the python side, for example monkeypatching methods, this has been simplified, and the overall result is that the representation is more honest about what is actually going on.
oyvindeide
force-pushed
the
rejoin_enkf_main
branch
from
18fe4d9
to
0c26efa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This joins the different classes that all point to the
underlying C++ object enkf_main so there is a 1 to 1
relationship. The reason for doing this is that the split
introduces a lot of complexity, and no real separation of
concerns, as the subclasses often have to call parent().
There was also a lot of additional complexity added on the
python side, for example monkeypatching methods, this has
been simplified, and the overall result is that the representation
is more honest about what is actually going on.
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.