Remove ERT splash + contextmanage GUILogHandler #3717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vast majority of ERT's initialisation time comes from Python and all of the imports that are required by ERT. By the time the splash screen is displayed this work has already been done. Additionally, we delay ERT's startup by an additional two seconds to show the splash screen. This is just annoying. (Changelog: "Improved ERT GUI startup times!")
pinkwah
force-pushed
the
gui-atexit
branch
2 times, most recently
from
df0870f
to
8fca01d
Compare
Without this, anything logged after Qt exits will still attempt to log to the GUILogHandler, causing an exception. This commit uses a contextmanager to cleanly remove the handler after exit.
Codecov Report
@@ Coverage Diff @@
## main #3717 +/- ##
==========================================
- Coverage 63.36% 62.73% -0.64%
==========================================
Files 594 592 -2
Lines 46007 45844 -163
Branches 4142 4127 -15
==========================================
- Hits 29151 28758 -393
- Misses 15565 15821 +256
+ Partials 1291 1265 -26
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove ERT Splash Window
The vast majority of ERT's initialisation time comes from Python and all
of the imports that are required by ERT. By the time the splash screen
is displayed this work has already been done.
Additionally, we delay ERT's startup by an additional two seconds to show
the splash screen. This is just annoying. (Changelog: "Improved ERT GUI
startup times!")
Add contextmanager for GUILogHandler
Without this, anything logged after Qt exits will still attempt to
log to the GUILogHandler, causing an exception. This commit uses a
contextmanager to cleanly remove the handler after exit.