Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove init_internalization from enkf_main #3719

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Aug 8, 2022

This sets the internalization flag for all observations to ensure
they are loaded, however it is only ever read for GEN_DATA which
always sets the flag on allocation.

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@oyvindeide oyvindeide added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Aug 8, 2022
@oyvindeide oyvindeide self-assigned this Aug 8, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3719 (3be2a62) into main (5355501) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3719      +/-   ##
==========================================
+ Coverage   63.37%   63.40%   +0.03%     
==========================================
  Files         594      594              
  Lines       46003    45978      -25     
  Branches     4142     4139       -3     
==========================================
- Hits        29153    29151       -2     
+ Misses      15561    15537      -24     
- Partials     1289     1290       +1     
Impacted Files Coverage Δ
src/libres/lib/enkf/enkf_main.cpp 43.47% <ø> (+2.36%) ⬆️
src/res/enkf/enkf_main.py 95.60% <ø> (-0.02%) ⬇️
src/ert/data/record/_transformation.py 88.57% <0.00%> (-0.48%) ⬇️
src/libres/lib/res_util/block_fs.cpp 67.34% <0.00%> (-0.41%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This sets the internalization flag for all observations to ensure
they are loaded, however it is only ever read for GEN_DATA which
always sets the flag on allocation.
@oyvindeide oyvindeide force-pushed the remove_init_init branch 2 times, most recently from 4792cf6 to 6c28008 Compare August 16, 2022 07:05
@oyvindeide oyvindeide merged commit 559e4e2 into equinor:main Aug 16, 2022
@oyvindeide oyvindeide deleted the remove_init_init branch August 16, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants