Fix flaky bug in test_ert_qstat_proxy #3731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berland
added
the
release-notes:maintenance
berland
changed the title
The subprocesses were not allowed to finished before the backend script was removed from path (provided by the testpath context manager) Also invert the MacOS test in the proxy script, so that it will fall back to backend on anything but Linux.
berland
force-pushed
the
fix_proxy_flakyness
branch
from
d789c43
to
460ad0c
Compare
xjules
reviewed
Aug 10, 2022
| if [[ $OSTYPE == "darwin"* ]]; then | ||
| # No sufficient file locking mechanism available on Mac OS X. Fallback: | ||
| if [ `uname` != "Linux" ]; then | ||
| # Fallback if we are not on Linux |
There was a problem hiding this comment.
Wasn't sure that it works, but it seems it does :)
|
Jenkins test required please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subprocesses were not allowed to finished before the backend script was removed
from path (provided by the testpath context manager)
Issue
Resolves unreported flakyness in test script for qstat proxy.
Approach
Extend lifetime of context manager
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.