Remove BLOCK_OBSERVATION keyword

[dafeda]

Pre review checklist

• Added appropriate release note label
• PR title captures the intent of the changes, and is fitting for release notes.
• Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

[codecov-commenter]

Codecov Report

Merging #3732 (2d042a8) into main (d20ddc3) will increase coverage by 0.13%.
The diff coverage is 53.84%.

@@            Coverage Diff             @@
##             main    #3732      +/-   ##
==========================================
+ Coverage   63.43%   63.57%   +0.13%     
==========================================
  Files         600      597       -3     
  Lines       45359    44777     -582     
  Branches     4091     4042      -49     
==========================================
- Hits        28774    28467     -307     
+ Misses      15328    15070     -258     
+ Partials     1257     1240      -17     

Impacted Files	Coverage Δ
src/clib/lib/config/config_parser.cpp	72.50% <0.00%> (-1.59%)	⬇️
src/clib/lib/enkf/enkf_node.cpp	37.94% <ø> (ø)
src/clib/lib/enkf/obs_vector.cpp	29.07% <ø> (+5.58%)	⬆️
src/ert/_c_wrappers/enkf/__init__.py	100.00% <ø> (ø)
.../_c_wrappers/enkf/enums/enkf_obs_impl_type_enum.py	100.00% <ø> (ø)
src/ert/_c_wrappers/enkf/observations/__init__.py	100.00% <ø> (ø)
..._c_wrappers/enkf/observations/block_data_config.py	57.14% <ø> (-21.43%)	⬇️
src/ert/_c_wrappers/enkf/plot_data/__init__.py	100.00% <ø> (ø)
src/ert/libres_facade.py	79.82% <ø> (+0.17%)	⬆️
src/clib/lib/enkf/enkf_obs.cpp	59.43% <100.00%> (-4.80%)	⬇️
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[dafeda]

test ert please

[oyvindeide]

This looks really nice! Did you check what happens when (if) someone runs a config with BLOCK_OBSERVATION after this?

[dafeda]

This looks really nice! Did you check what happens when (if) someone runs a config with BLOCK_OBSERVATION after this?

I added

BLOCK_OBSERVATION RFT_2006
{
   FIELD  = PRESSURE;
   DATE   = 2006-10-22;
   SOURCE = SUMMARY;

   OBS P1 { I = 1;  J = 1;  K = 1;   VALUE = 100;  ERROR = 5; };
   OBS P2 { I = 2;  J = 2;  K = 1;   VALUE = 101;  ERROR = 5; };
   OBS P3 { I = 2;  J = 3;  K = 1;   VALUE = 102;  ERROR = 5; };
};

to snake_oil_field/snake_oil.ert and ran ert gui snake_oil.ert, which throws the following.

2022-08-24 11:59:38,108 - res.config - WARNING - ** Warning keyword: BLOCK_OBSERVATION not recognized when parsing: snake_oil.ert ---
2022-08-24 11:59:38,108 - res.config - WARNING - ** Warning keyword: { not recognized when parsing: snake_oil.ert ---
2022-08-24 11:59:38,108 - res.config - WARNING - ** Warning keyword: DATE not recognized when parsing: snake_oil.ert ---
2022-08-24 11:59:38,108 - res.config - WARNING - ** Warning keyword: SOURCE not recognized when parsing: snake_oil.ert ---
2022-08-24 11:59:38,108 - res.config - WARNING - ** Warning keyword: OBS not recognized when parsing: snake_oil.ert ---
2022-08-24 11:59:38,108 - res.config - WARNING - ** Warning keyword: OBS not recognized when parsing: snake_oil.ert ---
2022-08-24 11:59:38,108 - res.config - WARNING - ** Warning keyword: OBS not recognized when parsing: snake_oil.ert ---
2022-08-24 11:59:38,108 - res.config - WARNING - ** Warning keyword: }; not recognized when parsing: snake_oil.ert ---

Error message: ensemble_config_init_FIELD: field type: PRESSURE; is not recognized

[oyvindeide]

LGTM!