Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary fixtures #3735

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Remove unnecessary fixtures #3735

merged 1 commit into from
Aug 12, 2022

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Aug 10, 2022

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@dafeda dafeda added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Aug 10, 2022
@dafeda dafeda requested a review from oyvindeide August 10, 2022 18:28
@dafeda dafeda self-assigned this Aug 10, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3735 (7f1a3a5) into main (f9042c7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3735   +/-   ##
=======================================
  Coverage   62.73%   62.73%           
=======================================
  Files         592      592           
  Lines       45844    45844           
  Branches     4127     4127           
=======================================
  Hits        28762    28762           
+ Misses      15818    15817    -1     
- Partials     1264     1265    +1     
Impacted Files Coverage Δ
src/libres/lib/res_util/block_fs.cpp 67.34% <0.00%> (-0.41%) ⬇️
src/ert/data/record/_transformation.py 89.04% <0.00%> (+0.47%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dafeda dafeda merged commit 6b3aa18 into equinor:main Aug 12, 2022
@dafeda dafeda deleted the remove_fixtures branch August 12, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants