Fetch storage server name, i.e. the config name, and use as title in webviz-ert #3767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortalisk
force-pushed
the
add_title
branch
5 times, most recently
from
48d6a33
to
404684a
Compare
| *, | ||
| res: LibresFacade = Depends(get_res), | ||
| ) -> Mapping[str, Any]: | ||
| return {"name": res.user_config_file} |
There was a problem hiding this comment.
Peahaps only return the name of the config file not the whole path to make it more readable in a small tab
frode-aarstad
approved these changes
Aug 17, 2022
Codecov Report
@@ Coverage Diff @@
## main #3767 +/- ##
==========================================
- Coverage 63.32% 63.31% -0.01%
==========================================
Files 600 601 +1
Lines 45678 45701 +23
Branches 4145 4145
==========================================
+ Hits 28926 28937 +11
- Misses 15476 15489 +13
+ Partials 1276 1275 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves equinor/webviz-ert#351
Approach
Make request to storage server before starting webviz-ert, and set it as the title in the webviz config.
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.