Fix the logging path when running the GUI #3772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frode-aarstad
added
the
release-notes:improvement
frode-aarstad
changed the title
frode-aarstad
force-pushed
the
fix_log_path
branch
2 times, most recently
from
a51f3d2
to
9d236d8
Compare
mortalisk
reviewed
Aug 17, 2022
src/ert/gui/gert_main.py
Outdated
| @@ -55,7 +55,6 @@ def run_gui(args): | |||
| "workflow_jobs": str(res_config.model_config.getForwardModel().joblist()) | |||
| }, | |||
| ) | |||
|
|
|||
mortalisk
reviewed
Aug 17, 2022
src/ert/logging/__init__.py
Outdated
| filename, extension = os.path.splitext(filename) | ||
| filename = ( | ||
| f"{filename}-" | ||
| f"{datetime.now().strftime(datetime.now().strftime('%Y-%m-%dT%H%M'))}" | ||
| f"{extension}" | ||
| ) | ||
|
|
||
| if "use_log_dir_from_env" in kwargs: |
There was a problem hiding this comment.
I suggest removing this line and putting a default value of False in the pop method below.
frode-aarstad
force-pushed
the
fix_log_path
branch
2 times, most recently
from
608aafd
to
55feed5
Compare
frode-aarstad
force-pushed
the
fix_log_path
branch
from
55feed5
to
cd7ebca
Compare
|
Jenkins: Test this please! |
mortalisk
approved these changes
Aug 19, 2022
|
Jenkins: Test this please! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #3588
Approach
Add the logging path to the environment that is sent to the subprocess then use this in the custom file handler.
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.