Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove enkf_main alloc enkf_fs from symlink #3773

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Aug 16, 2022

This was probably old funtionality to migrate from symlink
to current_case file. Storage is usually short-lived, so
this is unlikely to affect any users.

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@oyvindeide oyvindeide added the release-notes:breaking-change Automatically categorise as breaking change in release notes label Aug 16, 2022
@oyvindeide oyvindeide self-assigned this Aug 16, 2022
@oyvindeide oyvindeide force-pushed the clean_enkf_main_alloc branch 2 times, most recently from a7af811 to e880e36 Compare August 16, 2022 13:00
@oyvindeide oyvindeide enabled auto-merge (rebase) August 16, 2022 13:00
@codecov-commenter
Copy link

Codecov Report

Merging #3773 (d6b7a6b) into main (f3d9a86) will increase coverage by 0.06%.
The diff coverage is 93.70%.

❗ Current head d6b7a6b differs from pull request most recent head e880e36. Consider uploading reports for the commit e880e36 to get more accurate results

@@            Coverage Diff             @@
##             main    #3773      +/-   ##
==========================================
+ Coverage   62.57%   62.63%   +0.06%     
==========================================
  Files         592      592              
  Lines       45523    45521       -2     
  Branches     4149     4145       -4     
==========================================
+ Hits        28486    28514      +28     
+ Misses      15760    15733      -27     
+ Partials     1277     1274       -3     
Impacted Files Coverage Δ
src/libres/lib/enkf/obs_vector.cpp 23.48% <0.00%> (ø)
src/libres/lib/enkf/time_map.cpp 33.10% <0.00%> (ø)
src/libres/lib/sched/history.cpp 0.00% <0.00%> (ø)
src/res/enkf/enkf_main.py 95.59% <ø> (-0.02%) ⬇️
src/ert/gui/model/real_list.py 87.30% <91.42%> (-0.41%) ⬇️
src/ert/gui/model/progress_proxy.py 94.25% <96.42%> (-0.81%) ⬇️
src/ert/gui/model/snapshot.py 87.70% <97.14%> (+0.54%) ⬆️
src/ert/gui/model/job_list.py 85.60% <97.29%> (-0.76%) ⬇️
src/libres/lib/enkf/enkf_main.cpp 42.53% <100.00%> (+2.58%) ⬆️
src/libres/lib/enkf/subst_config.cpp 67.56% <100.00%> (+0.59%) ⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@oyvindeide
Copy link
Collaborator Author

test this please

This was probably old funtionality to migrate from symlink
to current_case file. Storage is usually short-lived, so
this is unlikely to affect any users.
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖

@oyvindeide oyvindeide enabled auto-merge (rebase) August 17, 2022 06:30
@oyvindeide oyvindeide merged commit fc11acb into equinor:main Aug 17, 2022
@oyvindeide oyvindeide deleted the clean_enkf_main_alloc branch August 17, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:breaking-change Automatically categorise as breaking change in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants