Remove refcounting from enkf_fs #3789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enkf_fs is now only owned from python in production code, so refcounting is handled automatically.
This has the positive side effect of allowing debugging of the enf_fs constructor as we are no longer trying to read a property in C that does not exist, this would previously segfault.
oyvindeide
force-pushed
the
remove_refcount
branch
from
c699d9d
to
7567e4b
Compare
Codecov Report
@@ Coverage Diff @@
## main #3789 +/- ##
==========================================
- Coverage 63.45% 63.43% -0.03%
==========================================
Files 600 600
Lines 45433 45372 -61
Branches 4098 4096 -2
==========================================
- Hits 28828 28780 -48
+ Misses 15345 15334 -11
+ Partials 1260 1258 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
def test_that_delete_works_as_expected(tmpdir):
with tmpdir.as_cwd():
assert not (Path("default") / "default.lock").exists()
fs = EnkfFs.createFileSystem("default")
assert (Path("default") / "default.lock").exists()
del fs
assert not (Path("default") / "default.lock").exists()not sure if this would add value, but is possible |
pinkwah
approved these changes
Aug 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
All file system creation outside tests are now in python, meaning that automatic refcounting should be handled automatically.
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.