Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove logging from umount #3803

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Remove logging from umount #3803

merged 1 commit into from
Aug 23, 2022

Conversation

oyvindeide
Copy link
Collaborator

If the logger was already deleted this causes problems.

Issue
everest crashes when cleaning up after tests.

Approach
Short description of the approach

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@oyvindeide
Remove logging from umount
c5461f6 
If the logger was already deleted this causes problems.
@oyvindeide oyvindeide self-assigned this Aug 23, 2022
berland
berland approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oyvindeide oyvindeide merged commit 4edccd5 into equinor:main Aug 23, 2022
@oyvindeide oyvindeide deleted the remove_logging branch August 23, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berland berland berland approved these changes

Assignees

@oyvindeide oyvindeide

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oyvindeide @berland