-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CONTAINER keyword #3834
Remove CONTAINER keyword #3834
Conversation
dfa32ce
to
eed0292
Compare
Codecov Report
@@ Coverage Diff @@
## main #3834 +/- ##
==========================================
+ Coverage 63.85% 64.06% +0.20%
==========================================
Files 595 593 -2
Lines 44580 44378 -202
Branches 4012 3977 -35
==========================================
- Hits 28467 28431 -36
+ Misses 14873 14719 -154
+ Partials 1240 1228 -12
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Did a quick search for |
Did you check if the failing workflow is related to the changes in this PR? |
I believe they are historical problems. Seems like clang-tidy runs on the files touched in the PR and reports old issues. Can have a look and see if they are easily solvable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good job cleaning! The file causing the annotation to fail will be removed in #3843 so no need to do anything about it in this PR.
496e026
to
3bd5518
Compare
3bd5518
to
e741547
Compare
Issue
Resolves #3747
Approach
Short description of the approach
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.