Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused strict-keyword from EnkfMain #3835

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Remove unused strict-keyword from EnkfMain #3835

merged 2 commits into from
Aug 30, 2022

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Aug 29, 2022 •
edited

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

oyvindeide
oyvindeide approved these changes Aug 30, 2022
View reviewed changes
Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 But if not too much work, could you put removing unused imports in a separate commit?

@dafeda dafeda self-assigned this Aug 30, 2022
@dafeda dafeda added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Aug 30, 2022
@dafeda
Copy link
Contributor Author

dafeda commented Aug 30, 2022

LGTM 👍 But if not too much work, could you put removing unused imports in a separate commit?

Thanks, fixed.

@dafeda dafeda merged commit 544b055 into equinor:main Aug 30, 2022
@dafeda dafeda deleted the enkfmain_strict branch August 30, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oyvindeide oyvindeide oyvindeide approved these changes

Assignees

@dafeda dafeda

Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
SCOUT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dafeda @oyvindeide