Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused function enkf_main_load_obs #3853

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Sep 2, 2022

Drive by cleaning

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@oyvindeide oyvindeide self-assigned this Sep 2, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3853 (53c0dcf) into main (431aea8) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3853      +/-   ##
==========================================
+ Coverage   63.86%   63.90%   +0.03%     
==========================================
  Files         595      595              
  Lines       44584    44572      -12     
  Branches     4012     4010       -2     
==========================================
+ Hits        28475    28482       +7     
+ Misses      14869    14850      -19     
  Partials     1240     1240              
Impacted Files Coverage Δ
src/clib/lib/enkf/enkf_main.cpp 28.84% <ø> (+1.32%) ⬆️
src/ert/ert3/engine/_sensitivity.py 88.63% <0.00%> (-6.37%) ⬇️
src/ert/ert3/engine/_export.py 89.55% <0.00%> (-3.90%) ⬇️
src/ert/gui/ertwidgets/models/ertmodel.py 50.00% <0.00%> (-1.73%) ⬇️
src/ert/ert3/engine/_run.py 95.23% <0.00%> (-1.51%) ⬇️
src/ert/gui/tools/plugins/plugin_handler.py 64.00% <0.00%> (-1.39%) ⬇️
src/ert/gui/ertwidgets/caselist.py 21.91% <0.00%> (-1.06%) ⬇️
...ert/gui/tools/plot/customize/customization_view.py 22.34% <0.00%> (-0.82%) ⬇️
.../config/plugins/implementations/transformations.py 94.28% <0.00%> (-0.46%) ⬇️
src/clib/lib/enkf/gen_obs.cpp 43.80% <0.00%> (-0.33%) ⬇️
... and 169 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@oyvindeide oyvindeide merged commit 31ad009 into equinor:main Sep 2, 2022
@oyvindeide oyvindeide deleted the remove_load_obs branch September 2, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants