Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor config fixes #3858

Conversation

valentin-krasontovitsch
Copy link
Contributor

Issue
Related generally to #3740, and more specifically to #2567.

Approach
In these two commits we

  • set two default values in the python path for model config
  • include the number of realizations parameter in the dict setup for config testing

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@valentin-krasontovitsch
Copy link
Contributor Author

btw: default values are taken from fmu-docs, list of all keywords

Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@valentin-krasontovitsch
Copy link
Contributor Author

github action running the ert tests keeps failing with different stuff - first it was a flaky / randomy test (#3870), then it was a timeout, the tests took longer than 30 minutes to run and got cancelled... restarted now.

@valentin-krasontovitsch valentin-krasontovitsch merged commit 7af77b2 into equinor:main Sep 12, 2022
@valentin-krasontovitsch valentin-krasontovitsch deleted the minor-config-fixes branch November 16, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants