Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where random seed would overflow #3863

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Sep 6, 2022

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@oyvindeide oyvindeide self-assigned this Sep 6, 2022
@oyvindeide oyvindeide added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Sep 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2022

Codecov Report

Merging #3863 (228c454) into main (a9cb917) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 228c454 differs from pull request most recent head 2f16ac5. Consider uploading reports for the commit 2f16ac5 to get more accurate results

@@            Coverage Diff             @@
##             main    #3863      +/-   ##
==========================================
- Coverage   63.76%   63.74%   -0.03%     
==========================================
  Files         588      588              
  Lines       43838    43838              
  Branches     3786     3786              
==========================================
- Hits        27955    27943      -12     
- Misses      14760    14773      +13     
+ Partials     1123     1122       -1     
Impacted Files Coverage Δ
src/ert/_c_wrappers/enkf/rng_config.py 88.23% <100.00%> (ø)
src/ert/gui/ertwidgets/validationsupport.py 79.45% <0.00%> (-19.18%) ⬇️
src/clib/lib/res_util/block_fs.cpp 67.62% <0.00%> (+0.40%) ⬆️
src/ert/data/record/_transformation.py 89.04% <0.00%> (+0.47%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@oyvindeide
Copy link
Collaborator Author

test required please

@oyvindeide
Copy link
Collaborator Author

Had to revert hypotesis test due to it taking to long

@oyvindeide oyvindeide enabled auto-merge (rebase) September 6, 2022 12:46
@oyvindeide oyvindeide merged commit fda53d5 into equinor:main Sep 6, 2022
@oyvindeide oyvindeide deleted the bug_rng branch September 6, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants