Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ert3 #3877

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Remove ert3 #3877

merged 1 commit into from
Sep 8, 2022

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Sep 7, 2022

Removes ert3. Bye bye for now 😢

The test have passed, but the required ert3 tests will have to be removed from the required list.

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@eivindjahren eivindjahren added the release-notes:ert3 Automatically categorise as ert3 change in release notes label Sep 7, 2022
@eivindjahren eivindjahren self-assigned this Sep 7, 2022
@eivindjahren eivindjahren force-pushed the remove_ert3 branch 7 times, most recently from 67eb863 to 939a52d Compare September 8, 2022 05:50
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2022

Codecov Report

Merging #3877 (e95c0e8) into main (52ce69c) will decrease coverage by 2.57%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3877      +/-   ##
==========================================
- Coverage   63.74%   61.16%   -2.58%     
==========================================
  Files         588      551      -37     
  Lines       43841    42003    -1838     
  Branches     3786     3790       +4     
==========================================
- Hits        27946    25691    -2255     
- Misses      14772    15187     +415     
- Partials     1123     1125       +2     
Impacted Files Coverage Δ
...rt/ensemble_evaluator/tracker/evaluator_tracker.py 72.00% <ø> (-0.23%) ⬇️
src/ert/gui/simulation/run_dialog.py 81.15% <ø> (+1.34%) ⬆️
src/ert/storage/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
src/ert/storage/_storage.py 0.00% <0.00%> (-89.46%) ⬇️
src/ert/data/record/_transmitter.py 56.66% <0.00%> (-37.78%) ⬇️
src/ert/data/record/_record.py 62.89% <0.00%> (-30.32%) ⬇️
src/ert/exceptions/_exceptions.py 70.96% <0.00%> (-29.04%) ⬇️
src/ert/data/record/_transformation.py 63.80% <0.00%> (-24.77%) ⬇️
src/ert/shared/services/storage_service.py 55.81% <0.00%> (-20.94%) ⬇️
src/clib/lib/job_queue/environment_varlist.cpp 13.15% <0.00%> (-16.26%) ⬇️
... and 15 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Farewell for now ert3 👋 😕

@sondreso sondreso merged commit 6a63703 into equinor:main Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:ert3 Automatically categorise as ert3 change in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants