Remove ert_test_context #3879
Merged
Remove ert_test_context #3879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eivindjahren
force-pushed
the
remove_ert_c_wrappers_test
branch
6 times, most recently
from
6039cea
to
79515fd
Compare
eivindjahren
force-pushed
the
remove_ert_c_wrappers_test
branch
3 times, most recently
from
6d5bb85
to
29b3e4b
Compare
eivindjahren
force-pushed
the
remove_ert_c_wrappers_test
branch
4 times, most recently
from
0d2bf9a
to
3d73ea5
Compare
Also converts the file to pytest from unittest
Also converts to pytest from unittest
Seemingly the field tests works even though they have been skipped. However, it also seems that default values and grid size has changed since the test was skipped. Also converts to pytest from unittest
eivindjahren
force-pushed
the
remove_ert_c_wrappers_test
branch
from
3d73ea5
to
c204ef2
Compare
|
This is just awesome 😌 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
As a part of #3798 we need to remove
src/ert/_c_wrappers/testPre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.