Remove deprecation limit on ert.data.loader.load_general_data and load.summary.data #3883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the deprecated_on argument. We failed to remove the deprecated functions (the test is a bit hard on failure) before 3.0 was released. Instead of removing the functions now and releasing 3.1, risking that our users will have to update fast, we remove the hard check on version. The warning of when the function will be removed has still been produced for 19 months.
lars-petter-hauge
added
the
release-notes:misc
sondreso
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the deprecated_on argument. We failed to remove the deprecated functions (the test is a bit hard on failure) before 3.0 was released. Instead of removing the functions now and releasing 3.1, risking that our users will have to update fast, we remove the hard check on version.
The warning of when the function will be removed has still been produced for 19 months.
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.