Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move parameter keys to ensemble_config #3901

Merged
merged 2 commits into from
Sep 21, 2022

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Sep 16, 2022

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@oyvindeide oyvindeide self-assigned this Sep 16, 2022
@oyvindeide oyvindeide added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Sep 16, 2022
@oyvindeide
Copy link
Collaborator Author

Test this please

@oyvindeide oyvindeide force-pushed the move_param_keys branch 2 times, most recently from efdbd3c to 7b61570 Compare September 19, 2022 11:49
@oyvindeide
Copy link
Collaborator Author

Test failure is related to protobuf and not this PR

@codecov-commenter
Copy link

Codecov Report

Merging #3901 (f16bb28) into main (bcc93d8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3901   +/-   ##
=======================================
  Coverage   58.51%   58.52%           
=======================================
  Files         545      545           
  Lines       41464    41461    -3     
  Branches     3764     3764           
=======================================
+ Hits        24264    24266    +2     
+ Misses      16199    16194    -5     
  Partials     1001     1001           
Impacted Files Coverage Δ
src/clib/lib/enkf/enkf_main.cpp 3.87% <ø> (+0.17%) ⬆️
src/ert/_c_wrappers/enkf/enkf_main.py 97.97% <100.00%> (ø)
src/ert/_c_wrappers/enkf/ensemble_config.py 92.12% <100.00%> (+1.80%) ⬆️
src/ert/job_runner/job.py 70.74% <0.00%> (-2.05%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@oyvindeide
Copy link
Collaborator Author

test c please

Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already started building on top of it!

@oyvindeide
Copy link
Collaborator Author

test this please

@oyvindeide oyvindeide merged commit c4274a5 into equinor:main Sep 21, 2022
@oyvindeide oyvindeide deleted the move_param_keys branch September 21, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants