Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin protobuf and grpcio-tools #3909

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Pin protobuf and grpcio-tools #3909

merged 1 commit into from
Sep 21, 2022

Conversation

xjules
Copy link
Contributor

@xjules xjules commented Sep 19, 2022

Issue
Test for ert_documentation fails due to we need to have the older version of protobuf package.

 _EMPTY = _descriptor.Descriptor(
/prog/res/komodo/bleeding-py38-rhel7/root/lib64/python3.8/site-packages/google/protobuf/descriptor.py:313: in __new__
    _message.Message._CheckCalledFromGeneratedFile()
E   TypeError: Descriptors cannot not be created directly.
E   If this call came from a _pb2.py file, your generated code is out of date and must be regenerated with protoc >= 3.19.0.
E   If you cannot immediately regenerate your protos, some other possible workarounds are:
E    1. Downgrade the protobuf package to 3.20.x or lower.
E    2. Set PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python (but this will use pure-Python parsing and will be much slower).

Approach
Short description of the approach

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@xjules xjules changed the title Pin protobuf version Pin protobuf and grpcio-tools Sep 20, 2022
@xjules
Copy link
Contributor Author

xjules commented Sep 20, 2022

Test ert please.

@lars-petter-hauge
Copy link
Contributor

I think we should at the same time investigate how we can remove the pin as well

@xjules
Copy link
Contributor Author

xjules commented Sep 21, 2022

I think we should at the same time investigate how we can remove the pin as well

Yes, I think we should. Although, I guess this falls onto resinisght / rips.

@xjules xjules self-assigned this Sep 21, 2022
@xjules xjules merged commit e2bbb4f into equinor:main Sep 21, 2022
@xjules xjules deleted the pin_protobuf branch September 21, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants