Remove c usage of res_config #3922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eivindjahren
force-pushed
the
remove_c_use_of_res_config
branch
22 times, most recently
from
dcdc7e1
to
7c78090
Compare
This function used a complicated way of setting ext_node from the outer scope which mypy was unable to type (also, difficult to read). This was simplified.
eivindjahren
force-pushed
the
remove_c_use_of_res_config
branch
2 times, most recently
from
da58634
to
ba4cdab
Compare
eivindjahren
force-pushed
the
remove_c_use_of_res_config
branch
from
ba4cdab
to
800a163
Compare
Codecov Report
@@ Coverage Diff @@
## main #3922 +/- ##
==========================================
+ Coverage 58.56% 58.69% +0.13%
==========================================
Files 545 545
Lines 41463 41277 -186
Branches 3765 3759 -6
==========================================
- Hits 24281 24229 -52
+ Misses 16181 16049 -132
+ Partials 1001 999 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
In order to simplify #3847 we can simplify the res_config object by not having references to it in the c code.
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.