Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up of enkf_node #3926

Merged
merged 7 commits into from
Sep 23, 2022
Merged

Clean-up of enkf_node #3926

merged 7 commits into from
Sep 23, 2022

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Sep 22, 2022

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@dafeda dafeda force-pushed the enkf_node branch 2 times, most recently from 008fa06 to 33111f3 Compare September 22, 2022 13:56
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2022

Codecov Report

Merging #3926 (15e41a0) into main (4d9ed75) will increase coverage by 20.40%.
The diff coverage is 0.00%.

❗ Current head 15e41a0 differs from pull request most recent head c448118. Consider uploading reports for the commit c448118 to get more accurate results

@@             Coverage Diff             @@
##             main    #3926       +/-   ##
===========================================
+ Coverage   38.24%   58.64%   +20.40%     
===========================================
  Files         132      545      +413     
  Lines       18432    41409    +22977     
  Branches     3765     3762        -3     
===========================================
+ Hits         7049    24284    +17235     
- Misses      10382    16124     +5742     
  Partials     1001     1001               
Impacted Files Coverage Δ
src/clib/lib/enkf/enkf_node.cpp 33.66% <0.00%> (+2.66%) ⬆️
src/ert/shared/cli/workflow.py 66.66% <0.00%> (ø)
src/ert/gui/gert_main.py 95.65% <0.00%> (ø)
src/ert/_c_wrappers/util/path_format.py 95.83% <0.00%> (ø)
src/ert/shared/plugins/plugin_response.py 100.00% <0.00%> (ø)
...valuator/narratives/monitor_successful_ensemble.py 100.00% <0.00%> (ø)
src/ert/_c_wrappers/fm/ecl/script.py 20.00% <0.00%> (ø)
src/ert/_c_wrappers/fm/rms/rms_config.py 100.00% <0.00%> (ø)
...rc/ert/shared/models/multiple_data_assimilation.py 95.34% <0.00%> (ø)
... and 405 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dafeda dafeda self-assigned this Sep 23, 2022
@dafeda dafeda added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Sep 23, 2022
@dafeda dafeda changed the title Enkf node Clean-up of enkf_node Sep 23, 2022
@dafeda dafeda marked this pull request as ready for review September 23, 2022 06:11
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dafeda dafeda merged commit ee012b1 into equinor:main Sep 23, 2022
@dafeda dafeda deleted the enkf_node branch September 23, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants