Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RSH_DRIVER from test config dict generation #3955

Merged

Conversation

DanSava
Copy link
Contributor

@DanSava DanSava commented Sep 28, 2022

Issue

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@DanSava DanSava self-assigned this Sep 28, 2022
@valentin-krasontovitsch valentin-krasontovitsch added configuration release-notes:breaking-change Automatically categorise as breaking change in release notes and removed configuration release-notes:breaking-change Automatically categorise as breaking change in release notes labels Sep 28, 2022
@valentin-krasontovitsch
Copy link
Contributor

oh, this is just removing it from the config dict generator - we don't want to go all the way and scratch the RSH driver completely?

@DanSava
Copy link
Contributor Author

DanSava commented Sep 28, 2022

oh, this is just removing it from the config dict generator - we don't want to go all the way and scratch the RSH driver completely?

We had a chat during the standup about removing it just from the dict generation, @mortalisk needs it as part of the issue he is working on also #2571 needs this change. So it is better to have it in now than to wait for #930 to be done

@valentin-krasontovitsch
Copy link
Contributor

I see! Thanks for explaining : )

@DanSava DanSava merged commit 6f185e2 into equinor:main Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants