Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log experiment type and size when a run model is instatiated #3967

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

ManInFez
Copy link
Contributor

@ManInFez ManInFez commented Sep 30, 2022

Storing what experiment is used for both cli and gui

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@ManInFez ManInFez self-assigned this Sep 30, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2022

Codecov Report

Merging #3967 (99d0232) into main (1955596) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 99d0232 differs from pull request most recent head 11357f0. Consider uploading reports for the commit 11357f0 to get more accurate results

@@            Coverage Diff             @@
##             main    #3967      +/-   ##
==========================================
- Coverage   58.04%   58.01%   -0.03%     
==========================================
  Files         544      544              
  Lines       41034    41037       +3     
  Branches     3772     3772              
==========================================
- Hits        23819    23809      -10     
- Misses      16232    16243      +11     
- Partials      983      985       +2     
Impacted Files Coverage Δ
src/ert/shared/cli/model_factory.py 96.61% <100.00%> (+0.18%) ⬆️
src/ert/gui/ertwidgets/validationsupport.py 79.45% <0.00%> (-19.18%) ⬇️
src/clib/lib/enkf/block_fs_driver.cpp 76.00% <0.00%> (-0.67%) ⬇️
src/clib/lib/res_util/block_fs.cpp 67.62% <0.00%> (-0.41%) ⬇️
src/ert/job_runner/job.py 72.78% <0.00%> (+2.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ManInFez
Copy link
Contributor Author

ManInFez commented Oct 3, 2022

Test this please!

@sondreso sondreso added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Oct 3, 2022
@ManInFez ManInFez merged commit 5da6935 into equinor:main Oct 3, 2022
@ManInFez ManInFez deleted the log_experiment_type branch October 3, 2022 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest hacktoberfest-accepted hacktoberfestivus release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants