Mute external DEBUG messages #3981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removed DEBUG logs from some packages that are not as critical to the ERT application.
Codecov Report
@@ Coverage Diff @@
## main #3981 +/- ##
==========================================
+ Coverage 58.28% 58.32% +0.03%
==========================================
Files 543 543
Lines 40767 40767
Branches 3723 3723
==========================================
+ Hits 23760 23776 +16
+ Misses 16001 15984 -17
- Partials 1006 1007 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
berland
added
the
improvement
hnformentin
reviewed
Oct 5, 2022
| shapely: | ||
| level: INFO | ||
| subscript: | ||
| level: INFO |
There was a problem hiding this comment.
- How did you choose the packages to be included here (h5py, shapely and subscript)? Was it based on the logs from Drogon?
- Is there a default option if we don't specify the level for a given package?
There was a problem hiding this comment.
These package names are taken from an observation of what fills up the terminal window (or the ert log files) when running Drogon or similar.
(the default is DEBUG, which is slightly unfortunate for some external packages that might be very chatty at this level, notably subscript.fmuobs.parsers in the case of Drogon.)
|
See also #3826 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removed DEBUG logs from some packages that are not as critical to the ERT application.
In particular, for Drogon,
subscript.fmuobs.parsersemit 200-300 lines of DEBUG messages when parsing the observations.Issue
Resolves overloading users and debuggers with not-so-interesting log messages.
Approach
Adjust the log-level on a per package level away from the default
DEBUG. This does not scale perfectly, as more packages introduced by users through configuration can still spur similar loads of debug messages.Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.