-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup log file for job_dispatch logger #3999
Setup log file for job_dispatch logger #3999
Conversation
cc1270f
to
33613f5
Compare
Getting error on type checking, but cannot recreate locally (updated mypy and friends).
It's missing type annotations on |
When I check our code we tend to use |
ff61dea
to
c337742
Compare
Codecov Report
@@ Coverage Diff @@
## main #3999 +/- ##
==========================================
- Coverage 58.73% 57.85% -0.89%
==========================================
Files 539 539
Lines 40101 40003 -98
Branches 3638 3600 -38
==========================================
- Hits 23554 23143 -411
- Misses 15533 15929 +396
+ Partials 1014 931 -83
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
767eb68
to
ad9b934
Compare
Make sure to clean up in case a test raises an exception. We could either end up not cleaning up temporary directory, or even never joining the thread and pytest will hang.
ad2c058
to
85dfc86
Compare
85dfc86
to
5deb42c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
By default python logging will go to stdout, which for calling job_dispatch will go into the void. We specify a logfile that currently we want placed into runpath (that is, one job_runner log file per realization).
Considering that we want to remove the abstraction of a runpath for the user we might want to reconsider where these logs eventually are placed.
Issue
Resolves #3998
Approach
Add logging configuration.
Pre review checklist
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.